-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mon/OSDMonitor: make mapping job behave if mon_osd_prime_pg_temp = false #13574
Conversation
dout(10) << __func__ << " started mapping job " << mapping_job.get() | ||
<< " at " << fin->start << dendl; | ||
mapping_job->set_finish_event(fin); | ||
if (g_conf->mon_osd_prime_pg_temp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes http://tracker.ceph.com/issues/19020 also, as src/test/erasure-code/test-erasure-code.sh sets mon_osd_prime_pg_temp to false.
could you add a "Fixes" tag in the commit message?
Make this robust to changes online too, so that we clean up a mapping job that was started, but only use it or start a new one if the option is true. Fixes: http://tracker.ceph.com/issues/19020 Signed-off-by: Sage Weil <sage@redhat.com>
9f2d57a
to
e00ef43
Compare
updated! |
retest this please. |
@tchaikov that failure looks unrelated. do you remember which test case it was though? |
@liewegas i think it's another form of http://tracker.ceph.com/issues/17743. |
Make this robust to changes online too, so that we clean up a mapping
job that was started, but only use it or start a new one if the
option is true.
Signed-off-by: Sage Weil sage@redhat.com